Code Review¶
All code must be code reviewed before being put into production environments.
Code review is essential for PCI compliance.
Checklist¶
- Ensure the functionality is solid:
- Ensure the functionality meets the Customer's Requirements.
- Ensure the functionality works in all of our Supported Browsers.
- Ensure the functionality is Performant.
- The code is efficient & does not negatively impact TTFB.
- The code does not have the ability to create an infinite loop.
- Ensure the functionality is Accessible.
- Ensure the functionality uses Ecommerce & SEO best-practices.
- Ensure the functionality has been QA'd.
- Ensure the functionality matches the Design mock-ups.
- Ensure that documentation is written/revised for the corresponding features.
- Ensure the code is clean:.
- Ensure the code is Secure.
- Ensure the code does not smell.
- Ensure the new/updated code passes the linting rules.
- Ensure the new/updated code is properly spaced & indented.
- Ensure the code uses the proper file settings & character-sets.
- Ensure the comments are clean, useful, explanatory, follow our guidelines.
- Ensure variables are appropriately named.