Pull Request Template¶
Use the template below when creating a pull request in BitBucket:
Summary¶
Summarize your changes and provide a link to the JIRA task.
Targeted Deployment Date¶
If applicable, add the deployment date in the following format: MM/DD/YY HH:MM AM/PM PST/EST
Testing¶
Test Environment¶
Please provide the following:
- The testing environment URL with the branch key.
- If applicable, the site protection access credentials.
- If applicable, the dev environment key in
theme-settings.json
to locally test the updates. For example:
"myDevEnvironment": {
"moduleRoot": "<%- MIVA_ROOT %>",
"themePath": "themes/mytheme/path/to/build/",
"proxyUrl": "<%- DEV_STORE_URL %>"
}
Test Cases¶
Please describe in detail how you tested your changes and provide some test case scenarios (or link to the JIRA QA task/story).
Tested in Browsers¶
Check the boxes on the browsers that you tested
- [ ] Mobile
- [ ] Chrome for Android
- [ ] iOs Safari
- [ ] Samsung Internet
- [ ] Desktop
- [ ] Mac
- [ ] Chrome
- [ ] Edge
- [ ] FireFox
- [ ] Safari
- [ ] Windows
- [ ] Chrome
- [ ] FireFox
- [ ] Edge
- [ ] Mac
Checklist¶
- [ ] Quality assurance testing according to our QA standards.
- [ ] Code reviewed according to our code review standards.
- [ ] Audit the impacted pages/components with Axe to ensure accessibility best-practices & fundamentals are not impacted negatively.
- [ ] Audit the impacted pages/components with Lighthouse to ensure accessibility, pagespeed, seo, and best-practice recommendations are not impacted negatively.
- [ ] Code conforms to the linters.
- [ ] Documentation or
README.md
has been revised or added to where it makes sense.